Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure measurements conform to SBOL 2.3 #2

Open
jakebeal opened this issue Jun 24, 2019 · 3 comments
Open

Make sure measurements conform to SBOL 2.3 #2

jakebeal opened this issue Jun 24, 2019 · 3 comments
Assignees
Milestone

Comments

@jakebeal
Copy link

We're adding measurements as annotations in a somewhat arbitrary namespace right now. We need to make sure that they're actually matching what's written in the SBOL 2.3 specification, and can be read by other software (e.g., libSBOLj)

@jakebeal jakebeal added this to the Beta milestone Jun 27, 2019
@jakebeal
Copy link
Author

Upload some of these, then assign it to me to audit and suggest changes.

@jakebeal
Copy link
Author

jakebeal commented Jul 30, 2019

Looking at some of the measures in the example you sent, we need one more layer here, to tie the properties of the measure together. Other than that, it looks good.

Basically, think what would happen if we tried to put two measurements on an item (e.g., it should be both 10 ng and 50% of the mass). Currently, with the measurement properties put directly on the object, they would end up intermingled (e.g., one couldn't tell whether it was 10 ng and 50% or 50 ng and 10%).

To fix this, you'd want to create an om-2#measure object that then has these properties inside of it. If this is, for some reason, impossible with pySBOL right now, then we can just leave this open for the time being --- as long as we have only 1 measurement per instance, we can survive.

@dashaveraksa
Copy link
Collaborator

Since the functions that take info from Excel files currently assume there is one measurement per functional component, I am reassigning this as 1.1 issue because it will require more than figuring out how to create a measurement object in SBOL.

@dashaveraksa dashaveraksa modified the milestones: Beta, 1.1 Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants