Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ability to Append PDF Pages to Reports in Sysreptor #242

Open
c-leitner opened this issue Apr 17, 2024 · 6 comments
Open

Comments

@c-leitner
Copy link

Adding functionality to append PDF pages to the end of a report in Sysreptor would greatly enhance the tool's flexibility and utility. This feature could be implemented either through a dedicated section in the user interface or at the time of report generation. It would be especially useful for incorporating documents from other software or including appendices like general terms and conditions, making the reports more comprehensive and valuable to users.

@aronmolnar
Copy link
Contributor

The disadvantage of this feature would be that the designs of the PDFs would differ and indexes like the table of contents would be incorrect, or even break (at least from the second document, i think). I'm also not sure what happens to other references within the PDF.

We're working on a solution to share the report and corresponding documents via SysReptor (#122) would it be a solution to upload other document as file and share it via SysReptor but as two different files?

Or would embedding documents help (like described in #41)? (But I don't know if this solution is technically feasible, we would have to have a look at it.)

Another solution would be to implement this feature as a reptor plugin, as CLI functionality.

@c-leitner
Copy link
Author

The primary goal is to include general terms and conditions when generating the report. These documents, typically not crafted by the pentest team, should not disrupt the main table of contents (TOC), appearing only as an appendix if necessary. This can be efficiently handled by appending the PDF at the time of the report’s publication and introducing a section titled 'Appendix'.

Currently, the solutions suggested in SysReptor (#122 ) and the embedding method mentioned in #41 don’t completely fulfill our specific needs. For now, I am in the process of developing a custom plugin that appends the PDF during report creation via the CLI, which directly addresses our immediate requirements. Meanwhile, I will continue to evaluate whether the other mentioned approaches might offer more seamless integration in the future.

@aronmolnar
Copy link
Contributor

Just as a small side note in case you don't know it.

Headings only appear in the ToC if they have the CSS class in-toc. You can add a static appendix in your design, in markdown or HTML format, for example:

image

@c-leitner
Copy link
Author

Thank you. I knew that, but as far as I know, it's not possible to add a PDF using that method. Am I mistaken?

@vysecurity
Copy link

Why not just paste the text in instead of trying to stick a PDF in?

@c-leitner
Copy link
Author

In some companies, the legal department generates terms and conditions in a specific style and format, providing them only as PDFs that should not be altered. These documents are regularly altered (by the legal team), and the legal team should not have access to sysreptor. I will solve this for now, with a CLI plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants