Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch: disable-check-route-option #74

Open
1 of 4 tasks
acomodi opened this issue Jun 7, 2019 · 1 comment
Open
1 of 4 tasks

Branch: disable-check-route-option #74

acomodi opened this issue Jun 7, 2019 · 1 comment
Labels
wip Work in Progress branch that needs work to be deleted/sent upstream

Comments

@acomodi
Copy link
Collaborator

acomodi commented Jun 7, 2019

Why did we need this? (what does this change enable us to do)

This is a temporary performance enhancement that allows to disable the check_route routine in several VPR steps (routing and genfasm).
The reasons behind the slow check routine run-time are still unknown, and it seems to affect only SymbiFlow tests.

What did it change?

Disables the check route routine in the vpr_api.cpp file.

Should it be merged upstream - if not, when can we delete it?

It should not be merged upstream. We can delete it as soon as the performance of check route are back to normal and do not slow down the whole VPR flow process.

What is needed to get this merged / deleted?

We need to explore the reasons behind the slow run-time of the check_route routine as trivially we cannot permanently disable it.

  • is the implementation work to make suitable for merging / deletion completed?
  • Is there an associated test?
  • is this currently part of the Conda package?
  • is this properly cleaned up in our local repositories?

Tracker / branch / PR & other useful links

Issue with more info: verilog-to-routing#537
code diff: verilog-to-routing/vtr-verilog-to-routing@master...SymbiFlow:disable-check-route-option

@litghost
Copy link

litghost commented Jun 7, 2019

This one can be removed when check-route isn't so slow.

@litghost litghost added this to Waiting for fix in Merge changes upstream Jun 7, 2019
@acomodi acomodi added the wip Work in Progress branch that needs work to be deleted/sent upstream label Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in Progress branch that needs work to be deleted/sent upstream
Projects
Merge changes upstream
  
Needs work to make suitable for upstream
Development

No branches or pull requests

2 participants