Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use from pip install #52

Open
FedeClaudi opened this issue Oct 31, 2020 · 4 comments
Open

Can't use from pip install #52

FedeClaudi opened this issue Oct 31, 2020 · 4 comments

Comments

@FedeClaudi
Copy link

Hi,

very cool package! I'm trying to integrate it with pyinspect to complement pyinspect's fancy tracebacks with your helpful messages, but I can't get didyoumean to work.
I've tried both with pip install BetterErrorMessages and by installing from the master branch on github, but it's the same.

I think that's in an issue about how modules are imported within the package, e.g.

from didyoumean.didyoumean_internal import add_suggestions_to_exception

results in:

ModuleNotFoundError: No module named 'didyoumean_re'

and

import didyoumean
didyoumean.didyoumean_api.didyoumean_postmortem()

results in:

AttributeError: module 'didyoumean' has no attribute 'didyoumean_api'

and so on..

@FedeClaudi
Copy link
Author

I think that the problem is related to what's discussed in this PR: #35

@alexmojaki
Copy link

I also think #50 would fix it.

I work around this in futurecoder with this:

import pygments  # can be any other pip installed module
site_packages = strip_required_suffix(pygments.__file__, "pygments/__init__.py")
sys.path.append(site_packages + "didyoumean/")
import didyoumean

@SylvainDe
Copy link
Owner

Thanks for the report ! I must confess that I am still haven't understood everything about making things pip usable...
I'll try some things locally based on #50 asap.

@FedeClaudi
Copy link
Author

Thanks @alexmojaki , I didn't know you could do that.
It's not very clean though, better to fix the path in the first place.
I've opened a PR for that: #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants