Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config setting "NORM_BEFORE_MLP" takes no effect #4

Open
flishwang opened this issue Jun 23, 2021 · 0 comments
Open

config setting "NORM_BEFORE_MLP" takes no effect #4

flishwang opened this issue Jun 23, 2021 · 0 comments

Comments

@flishwang
Copy link

flishwang commented Jun 23, 2021

in models/build.py:41,
the keyword passed to partial(SwinTransformer,...) is norm_befor_mlp,
while the keyword in SwinTransformer (models/swin_transformer.py:497) is norm_before_mlp.
The formmer missed a letter E compared with the latter.

Therefore, the 'bn' setting in configs takes no effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant