Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigint should be typed as "string" instead of "number" by default #93

Open
ellis opened this issue May 29, 2018 · 3 comments
Open

bigint should be typed as "string" instead of "number" by default #93

ellis opened this issue May 29, 2018 · 3 comments

Comments

@ellis
Copy link

ellis commented May 29, 2018

node-postgres returns Bigint columns as strings instead of numbers (by default), because they can be larger than javascript numbers. Could you please modify schemats to use "string" for bigint columns instead of "number"?

@abenhamdine
Copy link
Contributor

it would be even better if configurable, because it's quite usual to override node-postgres parser settings in order to parse bigint as integer.
See #51

@ellis
Copy link
Author

ellis commented Jun 20, 2018

FYI, I patched the code here: ellis@e2defb8

@narkowicz
Copy link

Note that TypeScript 3.2 adds support for bigint type.

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-2.html#bigint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants