Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1071 fix use camera and general permission request #1072

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wzy1935
Copy link

@wzy1935 wzy1935 commented May 21, 2022

Description

Changed files: Constants.java, ImageToPdfFragment.java, MainActivity.java, PermissionsUtils.java

  • Changing permission requirement. Now users using the "Image to pdf" function will also require camera permission.
  • Fix cancel permission feedback. Now when the user rejects to provide permissions, the popup window will show.

Fixes #1071

Type of change

Just put an x in the [] which are valid.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • ./gradlew assembleDebug assembleRelease
  • ./gradlew checkstyle

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codeclimate
Copy link

codeclimate bot commented May 21, 2022

Code Climate has analyzed commit db58ebe and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use camera when select images when creating pdf
1 participant