clude change language #1070
Closed
clude change language #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit a02967a and detected 0 issues on this pull request. View more on Code Climate. |
Swati4star
requested changes
May 13, 2022
| @@ -130,6 +130,6 @@ dependencies { | |||
| }) | |||
| } | |||
|
|
|||
| preBuild.dependsOn('checkstyle') | |||
| //preBuild.dependsOn('checkstyle') | |||
| @@ -14,6 +14,8 @@ | |||
| android:required="false" /> | |||
|
|
|||
| <uses-permission android:name="android.permission.CAMERA" /> | |||
| <uses-permission android:name="android.permission.CHANGE_CONFIGURATION" /> | |||
There was a problem hiding this comment.
I suppose this is not needed for language change.
| Bundle savedInstanceState) { | ||
|
|
||
| View view = inflater.inflate(R.layout.change_language, container, false); | ||
| button1 = view.findViewById(R.id.button1); |
There was a problem hiding this comment.
can we have better naming for these?
| @@ -135,9 +135,12 @@ public void onItemClick(int position) { | |||
| break; | |||
| case 7: | |||
| setShowPageNumber(); | |||
|
|
|||
Comment on lines
+235
to
+236
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added a button at the end of the application to jump to the language switching page.
Fixes #1065
Type of change
Just put an x in the [] which are valid.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
./gradlew assembleDebug assembleRelease./gradlew checkstyleChecklist: