Add Commitment Parameter to Solana JSON RPC Client #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. Appreciate the change however right now the structure is a bit different and we have commitment in individual methods defined as well. Might lead to conflicting structure. I think we overall need a revamp with how commitments are set tbh. Closing this for now due to the conflicting structure concern, but feel free to re-open if you can re-establish a better commitment passing structure so that we dont have to repeat it in specific instruction function from Client class |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "commitment" parameter is included in the RPC requests made by the client and the validation logic for the "commitment" parameter has been integrated as well
This PR fixes #41