Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document what happens when target has multiple addresses #15

Open
zloo opened this issue Apr 14, 2019 · 3 comments
Open

Document what happens when target has multiple addresses #15

zloo opened this issue Apr 14, 2019 · 3 comments

Comments

@zloo
Copy link

zloo commented Apr 14, 2019

Document what happens when target has multiple addresses.

How often do we resolve? What if the IP changes? What if there's multiple addresses? Do we ping all of them, or just the first one?

@SuperQ
Copy link
Owner

SuperQ commented Jun 6, 2019

Currently, we resolve once on startup, and only ping one.

@zloo
Copy link
Author

zloo commented Jun 17, 2019

ok, and do we want to keep that? we should at least honor the TTL and re-resolve when it expires.

regarding pinging multiple hosts, i think it makes sense to ping all resolved hosts, and we can distinguish between them via a label.

@SuperQ
Copy link
Owner

SuperQ commented Jun 30, 2019

I was working on an upstream change to the ping library to adjust the way it resolves. Still waiting for feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants