Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Song Data Grew Too Big” Error #111

Open
maxoakland opened this issue Dec 23, 2022 · 1 comment
Open

“Song Data Grew Too Big” Error #111

maxoakland opened this issue Dec 23, 2022 · 1 comment

Comments

@maxoakland
Copy link

maxoakland commented Dec 23, 2022

The Song Data Grew To Big Error Dialog box is too vague and written in a way that requires extra technical knowledge to decipher

Issues:

  • The title bar simply says “Error!” Instead of giving a clear explanation of the error
  • The first line says "There was an error assembling…” When this is where the error should be described (This is where "Song data is too large” should be put)
  • Rgbasm output adds a lot of detail that probably isn’t necessary for most users. This could be remedied with a “More Details” button that displays this
  • None of the text is selectable so copy & paste doesn’t work. What’s the point of showing all the extra info if we can’t paste it into a bug report?
  • Clicking OK automatically opens a page to the bug tracker. I think it would be nicer to have a button that says “Report Bug”/“Submit Report" and make it so “OK” Just closes the Window. I’m currently trying to make the song data small enough to fit. I don’t need to report a bug every single time I test to see if I removed enough data

Another big issue is that it doesn’t tell me how much extra song data I have. That would be helpful as I try to figure out what I need to fix

Also, I’m not sure if there’s a real technical limitation here, but it seems the limit of song data is very low

Also, documentation about things I can do to remedy this would be helpful. Like, does an effect take up more data than a note? What’s taking up my data?

Mockup of a more user friendly dialog box:
image

@SuperDisk
Copy link
Owner

The reason it's like this is because there isn't actually a specialized dialog box for the song getting too big-- any time RGBASM prints anything, it gets shown like this. Good suggestions though, I'll work on making it more user friendly. I'm also planning on having a report of the current song size in the status bar.

As for this:

Also, I’m not sure if there’s a real technical limitation here, but it seems the limit of song data is very low

That shouldn't be the case, unless you're creating a ton of unique patterns and not reusing any. Check out some of the sample songs and notice that they can be quite long (FADE's suit up and strap in for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants