Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow finer grained caching of metrics in metric_frequency #1218

Open
AntPAllen opened this issue Aug 9, 2023 · 1 comment
Open

Allow finer grained caching of metrics in metric_frequency #1218

AntPAllen opened this issue Aug 9, 2023 · 1 comment

Comments

@AntPAllen
Copy link

AntPAllen commented Aug 9, 2023

At the moment the metric_frequency processor caches metrics just based on the metric name. This means that metrics that come from for example kube-state-metrics aren't accurately reported due to the metrics being differentiated on attributes/labels. A suggestion would be to be able to cache the metrics where the key is a struct that contains both the metric name and its attributes.

@JonnySparrenhok
Copy link

It would also be great to have the ability to exclude certain services from being dropped by metric_frequency. Some services may have metrics that are very important to scrape as often as possible while others are fine to drop by metric_frequency. It would be a very appreciated feature if you add the ability to only apply metric_frequency to defined jobs/namespaces/metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants