Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 8 non full screen #81

Open
violet7 opened this issue Sep 19, 2014 · 16 comments
Open

iOS 8 non full screen #81

violet7 opened this issue Sep 19, 2014 · 16 comments

Comments

@violet7
Copy link

violet7 commented Sep 19, 2014

check background on iOS 8 iPad landscape

@dannyshmueli
Copy link

also iPhone 6 Landscape the background is not full screen:
ios simulator screen shot sep 21 2014 16 03 12

@PhillipApps
Copy link

Tested on iPhone 5, tapped on a button while landscape and this is the result.

img_0079

@djnivek
Copy link

djnivek commented Sep 22, 2014

Same issue for me ! Background non full screen on the iPad

@BobReid
Copy link
Contributor

BobReid commented Sep 22, 2014

The window bounds is now rotated to the device orientation on iOS 8. This is most likely the cause of the issue.

@BobReid
Copy link
Contributor

BobReid commented Sep 22, 2014

Submitted a PR for this
#82

@bfeher
Copy link

bfeher commented Sep 25, 2014

@BobReid's fix works perfectly. Thanks! I hope he accepts the PR soon.

@djnivek
Copy link

djnivek commented Sep 25, 2014

@BobReid thanks guy ! I've integrated your modification in my code, it works perfectly !

@ghost
Copy link

ghost commented Sep 30, 2014

@BobReid Many thanks It works perfectly also!

@BobReid
Copy link
Contributor

BobReid commented Oct 7, 2014

No problems guys.
Any plans to merge this? I would like to get rid of my fork! haha

@BobReid
Copy link
Contributor

BobReid commented Oct 8, 2014

Looks like the PR was merged.
Any plans for a cocoapods release?

@kerrmarin
Copy link

I'd like to echo BobReid's latest comment -- any plans for a cocoapods release?

@bfeher
Copy link

bfeher commented Apr 17, 2015

Am I doing something wrong or does this fix no longer work on 8.3?

@aydarin
Copy link

aydarin commented Jun 10, 2015

I have the same issue on iPad 2 and iPad mini with iOS 8.3
On other devices all works good

@adrum
Copy link

adrum commented Jul 7, 2015

I found the solution for 8.3+ here, except I didn't subclass UIViewController and it worked.

@twox
Copy link

twox commented Jul 25, 2015

The problem is in the absence of the rootController for SIAlertBackgroundWindow.
Try to fix method initFrame in the SIAlertView.m

@interface SIRootViewController : UIViewController

@end

@implementation SIRootViewController

- (BOOL)prefersStatusBarHidden
{
    return NO;
}

@end

@implementation SIAlertBackgroundWindow

- (id)initWithFrame:(CGRect)frame andStyle:(SIAlertViewBackgroundStyle)style
{
    self = [super initWithFrame:frame];
    if (self) {
        self.style = style;
        self.autoresizingMask = UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;
        self.opaque = NO;
        self.windowLevel = UIWindowLevelSIAlertBackground;

// Adding the  RootController for the background Window
        self.rootViewController = [[SIRootViewController alloc] init];
        self.rootViewController.view.backgroundColor = [UIColor clearColor];

    }
    return self;
}

@starock
Copy link

starock commented Aug 19, 2015

@BobReid Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests