Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes for calculation of the MessageLabel height and custom maximumNumberOfLines #103

Closed
wants to merge 3 commits into from

Conversation

SpacyRicochet
Copy link

  • Fix heightForMessageLabel erroneously uses titleLabel text for calculation #101 by making sure heightForMessageLabel uses the attributes from self.messageLabel instead of self.titleLabel.
  • Improve height calculation by removing the paragraphStyle attribute. Calculations mostly returned very small heights instead of the correct height.
  • Allow user to customise the maximumNumberOfLines by setting a UIAppearance property.

@ericertl
Copy link

Thanks @SpacyRicochet ! This helped me out. I hope someone creates a new branch and includes all the pull requests

SantiBec added a commit to SantiBec/SIAlertView that referenced this pull request Mar 23, 2016
@SpacyRicochet
Copy link
Author

Closing this, since it's been awhile and this project isn't active anymore.
Thanks for the hard work, maintainers! While I used this, it was great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heightForMessageLabel erroneously uses titleLabel text for calculation
2 participants