Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: ETag headers for static files #770

Open
njlr opened this issue Jan 16, 2023 · 1 comment
Open

Question: ETag headers for static files #770

njlr opened this issue Jan 16, 2023 · 1 comment

Comments

@njlr
Copy link
Contributor

njlr commented Jan 16, 2023

Is there already a mechanism for serving files with the ETag header properly set?

Given the cost of computing the ETag (likely a hash of the file) I think this should be an opt-in feature.
To amortize the cost of hashing, we may want to leverage FileSystemWatcher.

If not, happy to send a PR with a bit of design direction.

@ademar
Copy link
Member

ademar commented Jan 17, 2023

We do not have such mechanism. Certainly it would be nice if Suave had a way of generating etags, I am interested in seeing what you have in mind. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants