Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of Choice with Result? #766

Open
njlr opened this issue Jan 15, 2023 · 1 comment
Open

Replace usage of Choice with Result? #766

njlr opened this issue Jan 15, 2023 · 1 comment

Comments

@njlr
Copy link
Contributor

njlr commented Jan 15, 2023

I noticed much of the code-base uses Choice where Result would be more appropriate. Would this change be welcome?

Happy to send a PR.
@ademar
Copy link
Member

ademar commented Jan 15, 2023

In the places where it is used internally we can replace it. For public APIs I think we should hold this change for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ademar @njlr