Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locations reported should include end position #654

Open
anderseknert opened this issue Apr 16, 2024 · 1 comment
Open

Locations reported should include end position #654

anderseknert opened this issue Apr 16, 2024 · 1 comment

Comments

@anderseknert
Copy link
Member

Regal currently inherits location reporting from OPA, which only provides the start location of the AST node. Regal should extend this in it's output reports to try and always include an end location as well, as that provides a better experience in UI's like editors. If this is difficult to calculate, we'll just settle for end of line. For most violations though, I think this should be fairly trivial. It's still a lot of work though, as we'll need to do this for all the rules in Regal, and update the report formats accordingly.

@anderseknert
Copy link
Member Author

Here's a good example of a rule that would greatly benefit from this:

Screenshot 2024-05-15 at 13 35 52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: TODO
Development

No branches or pull requests

1 participant