Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The shell editor view doesn't initialize correctly #28

Closed
vqoph opened this issue Jan 28, 2016 · 13 comments
Closed

The shell editor view doesn't initialize correctly #28

vqoph opened this issue Jan 28, 2016 · 13 comments

Comments

@vqoph
Copy link

vqoph commented Jan 28, 2016

capture d ecran 2016-01-28 a 22 40 32

has you can see in the screenshot, the editor doesn't initialize correctly, does anyone have the same issue ?

to initialize this view i need to resize my browser window

@knownasilya
Copy link
Member

I see the same issue. It fixes if you open devtools. I've yet to find the cause.

Would love some eyes on it.

@vqoph
Copy link
Author

vqoph commented Jan 28, 2016

I can try to help but do you have any recommandation to contribute ?

@knownasilya
Copy link
Member

Well the codeblocks use https://github.com/angular-ui/ui-codemirror so maybe some dependency issues? Might be worthwhile cross posting there and see if they have any ideas.

The component is initialized here: https://github.com/Strider-CD/strider-custom/blob/master/config/config.html#L36

See strider repo for the actual dependency. Feel free to submit PRs and we can work on it together.

@vqoph
Copy link
Author

vqoph commented Jan 28, 2016

I've looked at angular-ui/ui-codemirror issues and the angular-ui/ui-codemirror#111 seems to be the same problem as our, i'll try their workaround

@vqoph
Copy link
Author

vqoph commented Jan 28, 2016

How do the project manage front end dependencies ? (it's the first time i contribute to a strider-cd plugin project)

@knownasilya
Copy link
Member

The frontend deps for this plugin are actually in strider itself (I think this is one of the older plugins).

P.S. maybe we can set ui-refresh to something better, like the current date..

@knownasilya
Copy link
Member

@vqoph
Copy link
Author

vqoph commented Jan 28, 2016

in strider project codemirror is set to 3.18.0 and latest is 5.11.1 may be an update of the library can solve our problem

@knownasilya
Copy link
Member

No, we would have to update angular as well, and it's a big project. But i think I know why it's not working 👍 Will try to fix in the next day or two.

@vqoph
Copy link
Author

vqoph commented Jan 28, 2016

ok i understand ,
i tryed to set ui-refresh to a time based value but i haven't found the right controller

@knownasilya
Copy link
Member

The issue is that the scope changes, so it breaks the setup.. trying to figure out the scope issue..

@knownasilya
Copy link
Member

Should be fixed in master branch of Strider repo.

@vqoph
Copy link
Author

vqoph commented Jan 29, 2016

Well it's working for me ! ;)
thx a lot for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants