Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken for Django 1.10 #19

Open
andrew-silvernail opened this issue Aug 25, 2016 · 2 comments
Open

Broken for Django 1.10 #19

andrew-silvernail opened this issue Aug 25, 2016 · 2 comments

Comments

@andrew-silvernail
Copy link

I've committed a PR for this problem, but the test suite seems broken.

@ghost
Copy link

ghost commented Jan 26, 2017

Patterns was deprecated after 1.8 and removed in 1.10, here is my fix for URLS.py

try:
    from django.conf.urls import url
except ImportError:
    from django.conf.urls.defaults import url, patterns  # Support for Django < 1.4
from dj_elastictranscoder.views import endpoint

urlpatterns = [
	# 'dj_elastictranscoder.views',
	url(
        regex=r'^endpoint/$',
        view=endpoint,
        name='endpoint',
    ),
    # url(r'^endpoint/$', 'endpoint'),
]

MODELS.py was broken as well as the if statement import was not working. I just removed the old code and left the following.

from django.contrib.contenttypes.fields import GenericForeignKey

@brandonrobertz
Copy link

brandonrobertz commented Jun 1, 2017

It's also broken due to the broken check on models.py line 4:

django.get_version() >= '1.8':

That always returns false (you, obviously, can't do a string check like that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants