import rules, groupings, and order enforced by lint #7094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkrives
reviewed
Oct 21, 2023
# Conflicts: # source/lib/storage.ts # source/views/home/index.tsx # source/views/views.ts
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7094 +/- ##
======================================
Coverage 8.47% 8.47%
======================================
Files 306 306
Lines 5225 5225
Branches 1404 1404
======================================
Hits 443 443
Misses 4755 4755
Partials 27 27 |
rye
approved these changes
Oct 23, 2023
|
@drewvolz This is what we have for the import plugin: 'import/extensions': ['error', { js: 'never', jsx: 'never', json: 'always', ts: 'never', tsx: 'never' }],
'import/named': 'error',
'import/no-cycle': 'off',
'import/no-namespace': 'warn',
'import/no-restricted-paths': ['warn', { zones: [{ target: './test', from: './app/actions' }] }],
'import/no-self-import': 'error',
'import/order': [
'warn',
{
groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'],
'newlines-between': 'never',
alphabetize: { order: 'asc', caseInsensitive: true },
},
],
'import/prefer-default-export': 'off',and {
files: ['test/**'],
env: { node: true },
extends: ['plugin:@typescript-eslint/recommended-type-checked', 'plugin:@typescript-eslint/stylistic'],
rules: {
'import/no-extraneous-dependencies': ['error', { devDependencies: true }], |
hawkrives
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7093
eslint-plugin-importeslint-plugin-simple-import-sortImport rules to take into account:
Import groupings to ensure:
reactrelated packages come first.react-native-*community packages..last..last.Room for improvement here, plenty of room for feedback.