Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button module tap target is only the height of the text #6368

Open
drewvolz opened this issue Sep 3, 2022 · 0 comments
Open

Button module tap target is only the height of the text #6368

drewvolz opened this issue Sep 3, 2022 · 0 comments
Labels
platform/android

Comments

@drewvolz
Copy link
Member

drewvolz commented Sep 3, 2022 •
edited by hawkrives

At least for Android, we should refactor modules/button away from the react-native-button dependency.

BasicButton has a small tap target equal to the height of the text. We should allow for the button to be part of the tap target (which this component's styles enable for iOS).

We could replace this on Android with react-native-paper's Button for a much more material look/feel.

Android iOS
2022-09-03 16 35 15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform/android
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drewvolz