New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with ConfigInitializer not supporting the new OAuth #1145
Comments
The enable in oauth is actually not necessary, if oauth is activated, then the function is activated. Or have I thought incorrectly about that? |
it could be done via a config presence check instead of a enable flag itself but due to how spring beans work it needs some conditional check |
There should be clarity by checking the issuer, clientId and clientSecret |
Fixed by splitting settings.yml and custom_settings.yml |
Im a idiiot keeping this open |
ConfigInitializer script is done badly and doesnt support 3 layered configs like the OAuth section. And has issues with tags of same name (two enabled etc)
Script should be fixed to allow better merging of yml files etc
The text was updated successfully, but these errors were encountered: