Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support Support fmt/7.1.x, string-view-lite/1.6.0, and variant-lite/2.0.0 #129

Open
prince-chrismc opened this issue Nov 10, 2020 · 3 comments

Comments

@prince-chrismc
Copy link
Contributor

The title includes a list of RESTinio dependencies which have seen update(s) in recent weeks/months.
Not include are the PRCE and PREC2 which have also seen updates, the ones above have more integration challenges however (as the they are not optional to restinio).

  • I quickly tested fmt/7.1.2 against restinio/0.6.12 and there was a complication failure with restinio::optional (I did not save the logs unfortunately)
  • I have successfully used string-view-lite/1.6.0 in a project along with RESTinio without any issue.
  • I have never tried the latest major release of variant, though the release notes do not suggest and API break I assume there is one.

As always any time you spent looking at this would be greatly appreciated ❤️

@eao197
Copy link
Member

eao197 commented Nov 11, 2020

Do you use RESTinio in C++17?

@eao197
Copy link
Member

eao197 commented Nov 11, 2020

I've updated RESTinio to fmtlib-7.1.2 in 0.6-dev-0.6.13-update-deps branch and checked it with a couple of different versions of different compilers with C++14 and C++17, and doesn't found any compilation errors.

@prince-chrismc
Copy link
Contributor Author

prince-chrismc commented Nov 11, 2020

I had tested in in GCC 9 which might be 17 by default, it might have been bad example code but I am glad it worked

I am trying to compile this example (slightly reduced) https://github.com/Stiffstream/restinio/blob/a6a07d147a04192cd0f590492ce6dd321597d54c/README.md#enhanced-example-with-express-router

I pushed a commit that was failing.

prince-chrismc added a commit to prince-chrismc/conan-center-index that referenced this issue Nov 11, 2020
conan-center-bot pushed a commit to conan-io/conan-center-index that referenced this issue Nov 12, 2020
* bump restinio/0.6.12 + upgrade deps

fmt/7.1.x does not work
havent testing variant-lite/2.0.0

* testing upgrading deps (fails)

based on Stiffstream/restinio#129

* bumping more deps + minify example to avoid compliation errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants