Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running on 32-bit system causes Narrowing Conversion error #124

Open
TremblingOdin opened this issue Aug 26, 2020 · 3 comments
Open

Running on 32-bit system causes Narrowing Conversion error #124

TremblingOdin opened this issue Aug 26, 2020 · 3 comments

Comments

@TremblingOdin
Copy link

I installed the restinio:x86-windows vcpkg and after it built fine, running it created the following error:
restinio\impl\parser_callbacks.ipp(163): error C2397: conversion from 'uint64_t' to 'size_t' requires a narrowing conversion

The 64 bit version works fine, but I would like to also be able to run on 32 bit systems since some companies still use legacy hardware

If you do not intend to support 32 bit that is understandable and just let me know

@eao197
Copy link
Member

eao197 commented Aug 27, 2020

Thanks for reporting this issue.

We don't test RESTinio in 32-bit mode usually, but I know that RESTinio works in 32-bit environment (GCC reports warning, not error for that line).

I'll fix the code in parser_callbacks.ipp in the near future.

@eao197
Copy link
Member

eao197 commented Aug 28, 2020

I've made some fixes in 0.6-dev branch.

I have no plans to release those updates as a new version. I want those changes will be a part of the upcoming v.0.6.11, but there is no planned release date yet.

If this issue is critical to you then let me know, I'll release 0.6.10.1.

@TremblingOdin
Copy link
Author

It's not a choke point, and there is a work around, but wanted to make an issue so that as I kept up to date with Restinio I wouldn't have to keep redoing the work around. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants