Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LC0016 - ignores ShowCaption property #579

Closed
sit-zm opened this issue Apr 2, 2024 · 5 comments
Closed

LC0016 - ignores ShowCaption property #579

sit-zm opened this issue Apr 2, 2024 · 5 comments
Labels
bug Something isn't working question Further information is requested

Comments

@sit-zm
Copy link

sit-zm commented Apr 2, 2024

LC0016 warning is shown even if ShowCaption = false for the group property on page.

image

Best,
Zoran M.

@Arthurvdv Arthurvdv added the bug Something isn't working label Apr 3, 2024
@Arthurvdv
Copy link
Collaborator

There's already an check in place for the ShowCaption property, so the rule shouldn't be raised.

I'm having trouble to reproduce this, because with the examples below the LC0016 diagnostic isn't raised.

Can you provide a small code sample to reproduce this bug?

page 50100 MyPage
{
    Caption = 'MyPage';

    layout
    {
        area(Content)
        {
            group(MyGroup)
            {
                ShowCaption = false;
            }
        }
    }
}

pageextension 50100 "Customer Card" extends "Customer Card"
{
    layout
    {
        addafter(General)
        {
            group(MyGroup)
            {
                ShowCaption = false;
            }

        }
    }
}

@Arthurvdv Arthurvdv added the question Further information is requested label Apr 6, 2024
@sit-zm
Copy link
Author

sit-zm commented Apr 8, 2024

Hi Arthur,

The sample is below. You can test it out.

pageextension 50000 DYCEMyExtension extends "Warehouse Shipment"
{
    layout
    {
        addlast(Shipping)
        {
            group("DYCEShippingTo")
            {
                Caption = 'Shipping To';

                field("DYCE Ship-To"; Rec."Assigned User ID")
                {
                    ApplicationArea = All;
                    Caption = 'Ship-to';
                    ToolTip = 'Specifies the address that the products on the sales document are shipped to. Default (Sell-to Address): The same as the customer''s sell-to address. Alternate Ship-to Address: One of the customer''s alternate ship-to addresses. Custom Address: Any ship-to address that you specify in the fields below.';
                }
                group(DYCEShipToFields)
                {
                    ShowCaption = false;
                }
            }
        }
    }
}

image

DYCE is mandatory prefix but that does not change the issue.

Best,
Zoran M.

@pri-kise
Copy link

I don't receive the warning LC0016 in my local deveopment environment (preview version), but I receive it in our pipelines
e.g. for CueGroup

@Arthurvdv
Copy link
Collaborator

I'm having trouble to reproduce this. A copy of your example doesn't thrown an warning for me 🤔

image

Can you very you have the latest LinterCop.dll (0.30.19.0) version?

%userprofile%.vscode\extensions\ms-dynamics-smb.al-13.0.1007491\bin\Analyzers

image

@sit-zm
Copy link
Author

sit-zm commented May 20, 2024

Now it works OK.

I have the latest version BusinessCentral.LinterCop.dll
image
image
image

@sit-zm sit-zm closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants