Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LC0052 Wrong for Quotation Marks #522

Open
pri-kise opened this issue Jan 29, 2024 · 3 comments · Fixed by #633
Open

LC0052 Wrong for Quotation Marks #522

pri-kise opened this issue Jan 29, 2024 · 3 comments · Fixed by #633
Labels

Comments

@pri-kise
Copy link

We created a procedure in a table extension with the following syntax where I receive the warning
"The internal method PTE-XXX-IsDeletable in TableExtension PTE-XXX Job (Access = Public) is declared but never used."

    internal procedure "PTE-XXX-IsDeletable"(): Boolean
    begin        
        exit(true);
    end;

Maybe the procedure name isn't parsed correctly?

@Arthurvdv Arthurvdv added the enhancement New feature or request label Jan 29, 2024
@Arthurvdv
Copy link
Collaborator

internal procedure "PTE-XXX-IsDeletable"(): Boolean
internal procedure IsDeletable(): Boolean

I've looked into this and the Code Analyser can see the right naming of the procedures.

image

But when we grab the Name of the object, both of them become the same string.

image

At the moment I have no idea howto handle the quotes on this 🤔

@Pazzakara
Copy link

What do you think about a new rule: "procedure names should not contain quotation marks"?

@Arthurvdv
Copy link
Collaborator

image
I've found a solution for the Quotation Marks and the method and object now matches according their name.

What do you think about a new rule: "procedure names should not contain quotation marks"?

For me personally I'm not against having quotation marks in procedure names. Best to start a new discussion on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants