Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify import #42

Open
csemken opened this issue Jun 3, 2020 · 1 comment
Open

Simplify import #42

csemken opened this issue Jun 3, 2020 · 1 comment

Comments

@csemken
Copy link
Contributor

csemken commented Jun 3, 2020

Currently, the import for Stargazer is unnecessarily convoluted:

from stargazer.stargazer import Stargazer 

I suggest we simplify it to:

from stargazer import Stargazer 

Which can be done by adding the following line to __init__.py:

from .stargazer import Stargazer 

This change is backwards-compatible.

@toobaz
Copy link
Collaborator

toobaz commented Jun 4, 2020

@csemken I certainly was planning to do this. But maybe it would be a good occasion to apply #44 - hence not just doing a transparent import, but really creating a new initialization class (with the idea to deprecate the older API, and hence the from stargazer.stargazer import Stargazer, in the long term).

Thoughts? (also @MaxGhenis @mwburke )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants