Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support tokenize function #45119

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dujijun007
Copy link
Contributor

@dujijun007 dujijun007 commented May 6, 2024

Why I'm doing:

The different results of tokenization provided by various tokenizers are too vague to users, so we need a tokenize function to allow users to figure it out easily.

What I'm doing:

Support a tokenize function, like tokenize(<tokenizer_name>, <content>)

Fixes #45145

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@dujijun007 dujijun007 requested review from a team as code owners May 6, 2024 09:25
be/src/exprs/gin_functions.h Outdated Show resolved Hide resolved
@dujijun007 dujijun007 force-pushed the main-support-tokenize-funciton branch from b368173 to 5536c53 Compare May 6, 2024 09:27
@dujijun007 dujijun007 force-pushed the main-support-tokenize-funciton branch from 5536c53 to c10ab97 Compare May 6, 2024 09:42
@dujijun007 dujijun007 changed the title [Feature] Support tokenize function [Enhancement] Support tokenize function May 6, 2024
@dujijun007 dujijun007 force-pushed the main-support-tokenize-funciton branch from c10ab97 to 49e7d23 Compare May 6, 2024 09:46
Signed-off-by: leorishdu <18771113323@163.com>
@dujijun007 dujijun007 force-pushed the main-support-tokenize-funciton branch from 49e7d23 to 923dbc4 Compare May 6, 2024 11:51
@imay
Copy link
Contributor

imay commented May 6, 2024

@dujijun007 thank you for the contribution, could you create an issue to describe this new function?
About its interface, input, output and limits?

@dujijun007
Copy link
Contributor Author

dujijun007 commented May 6, 2024

@dujijun007 thank you for the contribution, could you create an issue to describe this new function? About its interface, input, output and limits?

@imay ok, link it here(#45145)

Signed-off-by: leorishdu <18771113323@163.com>
@dujijun007 dujijun007 force-pushed the main-support-tokenize-funciton branch from f69928c to e4247fc Compare May 10, 2024 07:45
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 55 / 57 (96.49%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exprs/gin_functions.cpp 55 57 96.49% [71, 91]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tokenize function
2 participants