Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in p1 feature array #21

Open
lewj85 opened this issue May 4, 2024 · 0 comments
Open

Typo in p1 feature array #21

lewj85 opened this issue May 4, 2024 · 0 comments

Comments

@lewj85
Copy link

lewj85 commented May 4, 2024

The PantheonRL environment wrapper for overcookedgym uses an old version of HumanCompatibleAI's overcooked_ai repo under the hood. Unfortunately, this old version contains a typo in the p1 feature array here: https://github.com/HumanCompatibleAI/overcooked_ai/blob/6eaceb0a9a2501f1b9fccbf4c7016d6662ed1108/overcooked_ai_py/mdp/overcooked_mdp.py#L1157

Instead of
abs_pos_p1 = np.array(p0.position)
it should be
abs_pos_p1 = np.array(p1.position)

This needs to be refactored to wrap a more recent version of that overcooked_ai repo where the feature array typo was fixed. Or this file needs to be corrected after cloning the old repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant