Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting requests/limits on init containers #368

Open
agracie opened this issue Jun 28, 2023 · 2 comments
Open

Allow setting requests/limits on init containers #368

agracie opened this issue Jun 28, 2023 · 2 comments
Labels
feature help wanted Extra attention is needed K8s

Comments

@agracie
Copy link

agracie commented Jun 28, 2023

I'm trying to deploy stackstorm-k8s into an environment that enforces resourcequota requiring limits to be defined to all containers and init containers. This environment does not provide a limit range or default namespace limits. It would be very helpful to be able to define resources and limits of the individual init containers or have a default values/limits set for them.

@chain312
Copy link

chain312 commented Mar 6, 2024

You can refer to st2web for other component configurations in values.yaml

st2web:
  # Minimum 2 replicas are recommended to run st2web in HA mode
  replicas: 2
  # Tested resource consumption based on multiple requests to st2web within nginx
  # Please adjust based on your conscious choice
  resources:
    requests:
      memory: "25Mi"
      cpu: "50m"
    limits:
      memory: "100Mi"

@cognifloyd cognifloyd added help wanted Extra attention is needed feature K8s labels Apr 11, 2024
@cognifloyd
Copy link
Member

cognifloyd commented Apr 11, 2024

PR welcome. You'll need to add the resources section to each of the init containers. I count 13 init containers defined in:

These are all pretty basic utility containers that do not need many resources. Is there a default we could put here? Or perhaps add a value like utilityResources (we have image.utilityImage to set the image, though we should not put resources under image)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature help wanted Extra attention is needed K8s
Projects
None yet
Development

No branches or pull requests

3 participants