Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(rich-text) selection that includes link will move link popover to top of selection #200

Open
yellis opened this issue Jul 17, 2022 · 1 comment
Labels
bug Something isn't working mode - rich text Affects the editor's rich text (wysiwyg) mode
Milestone

Comments

@yellis
Copy link
Contributor

yellis commented Jul 17, 2022

Describe the bug
n rich text mode, when selecting a link and moving upwards, the link popover is also moved up vertically to under blocks that aren't links.

To Reproduce

  1. RT mode, type in a few lines of text
  2. Make a link towards the bottom
  3. Start to highlight from bottom to top
  4. Observe: link popover stays visible, and is stuck to the top of the selected area

Expected behavior
No link popover visible unless the selection is only on one link. Otherwise only show the link popover when the cursor is on the link.

Screenshots
demo

Desktop (please complete the following information):
Windows 11 Chrome 103

Additional context
https://meta.stackexchange.com/a/380439/51

@yellis yellis added bug Something isn't working mode - rich text Affects the editor's rich text (wysiwyg) mode labels Jul 17, 2022
@yellis yellis added this to the Beta 3 milestone Jul 18, 2022
@b-kelly
Copy link
Collaborator

b-kelly commented Jul 18, 2022

Popover is currently following the selection $anchor, should be instead following the selection $head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mode - rich text Affects the editor's rich text (wysiwyg) mode
Projects
Status: Todo
Development

No branches or pull requests

2 participants