Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataInputStream/DataOutputStream modified UTF-8 has incorrect encoding #51

Open
XerTheSquirrel opened this issue Sep 7, 2019 · 0 comments
Assignees
Labels
api An API bug compatibility Compatibility Issues
Milestone

Comments

@XerTheSquirrel
Copy link
Member

XerTheSquirrel commented Sep 7, 2019

The modified UTF-8 that these methods read and write are not done so correctly and will result in compatibility issues outside of ASCII.

The length of the string in characters is read/written where it should be the number of bytes used to represent the modified UTF-8 stream. This will work for ASCII but will break if NUL or anything higher than character 127 is used.

@XerTheSquirrel XerTheSquirrel added bug compatibility Compatibility Issues labels Sep 7, 2019
@XerTheSquirrel XerTheSquirrel added this to the Version 0.4.0 milestone Sep 7, 2019
@XerTheSquirrel XerTheSquirrel self-assigned this Sep 7, 2019
@XerTheSquirrel XerTheSquirrel added this to To do in Version 0.4.0 (Dev 0.3.0) via automation Sep 7, 2019
@XerTheSquirrel XerTheSquirrel changed the title DataInputStream/DataOutputStream modified UTF-8 incorrect DataInputStream/DataOutputStream modified UTF-8 has incorrect encoding Sep 7, 2019
@XerTheSquirrel XerTheSquirrel added the api An API label Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api An API bug compatibility Compatibility Issues
Projects
Development

No branches or pull requests

1 participant