Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish chapter "Commander: A powerful and simple command framework" #86

Open
4 tasks
koendehondt opened this issue Apr 19, 2024 · 0 comments
Open
4 tasks
Milestone

Comments

@koendehondt
Copy link
Collaborator

koendehondt commented Apr 19, 2024

  • Check all code examples and images

Open issues from #63:

  • testRemoveContact under "Adding the Remove Contact command" is not a good test. The initial items are not specified and more importantly, the test does not verify that the selected contact has been removed. It just checks that there is one contact less than initially.
  • Under "Enabling shortcuts", it reads "At the time of writing this chapter, Commander management of shortcuts has not been pushed to Spec to avoid dependency on Commander.". Is that still correct? I did not check that yet.
  • This chapter mentions toolbars, but it does not add a toolbar to a window.
@koendehondt koendehondt added this to the Book release milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant