Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment to chapter 15 #39

Open
LNUitTutor opened this issue Aug 20, 2023 · 0 comments
Open

Comment to chapter 15 #39

LNUitTutor opened this issue Aug 20, 2023 · 0 comments

Comments

@LNUitTutor
Copy link

p. 141 “EgContactBook >> add: contactName phone: phone
| contact | contact := EgContact new name: contactName; phone: phone.” – should be “EgContact name: contactName phone: phone.” with help of the class method.

p. 145

  • Subsection Layout “EgContactBookPresenter class >> defaultSpec” – should be EgContactBookPresenter >> defaultLayout.
  • Subsection Widget initialization “… table addColumn: (StringTableColumn…” should be SpStringTableColumn.
  • Subsection Widget initialization “table items: contactBook contents.” The contact book has not method contents. Two different accessors mentioned in the next chapter: contents and contacts. We should decide which one is needed and declare it. It is evident that only an accessor must be declared.
  • Subsection Widget initialization – bad formatting: “… the UI by executing the following snippet(EgContactBookPres” – should inser a space after “snippet”.

p. 146 Subsection Interacting with user “^ EgContact new name: splitted first; phone: splitted second; yourself” – should use the appropriate class method “^ EgContact name: splitted first phone: splitted second

p. 147 Subsection Some extra methods “EgContactBookPresenter >> isContactSelected ^ self table selectedItems isNotEmpty” – self is needless, should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant