Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer requires the current user level instead of always admin level #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Installer requires the current user level instead of always admin level #79

wants to merge 1 commit into from

Conversation

SpriteOvO
Copy link
Owner

Closes #77.

We use an undocumented option CPACK_NSIS_DEFINES to override the value of RequestExecutionLevel as highest, which causes the generated installer to ask admin privilege for admin users and normal user privilege for standard users.

This undocumented option conflicts with CPACK_COMPONENTS_ALL (https://cmake.org/Bug/view.php?id=14522)

Blocked by https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8767

CPack/NSIS currently has a bug that sets C:\Program Files (x86) as the default installation path for standard users, who does not have write access to this path.

@SpriteOvO
Copy link
Owner Author

CC @aetrnm, could you try the new installer after the CI completes compilation and give some feedback?

It currently has a known issue where the default installation path is incorrect and you need to manually change it to a directory that you have permission to write to. This will be fixed when the upstream MR (that Blocked By link) is merged.

@SpriteOvO
Copy link
Owner Author

Oh, I'm sorry. I mentioned the wrong person. I should CC @amwihgu.

@amwihgu
Copy link

amwihgu commented Sep 5, 2023

Oh, I'm sorry. I mentioned the wrong person. I should CC @amwihgu.

CC @aetrnm, could you try the new installer after the CI completes compilation and give some feedback?

It currently has a known issue where the default installation path is incorrect and you need to manually change it to a directory that you have permission to write to. This will be fixed when the upstream MR (that Blocked By link) is merged.

Hello,
Great news, I tried directly and found it working!
Thanks for the update!

@amwihgu amwihgu mentioned this pull request Feb 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayiyo01 mayiyo01 mayiyo01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Non-admin appreviledge?
3 participants
@SpriteOvO @amwihgu @mayiyo01