Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] NPM dependency with group not detected(!?). E.g. npm("@fontsource/inter", "_") #718

Open
jschneider opened this issue Apr 16, 2024 · 2 comments

Comments

@jschneider
Copy link

When adding a dependency to a NPM dependency including a group, the versions are not updated recognized.

kotlin {
  js {
    nodejs()
  }

  sourceSets {
    jsMain {

      dependencies {
           implementation(npm("@fontsource/inter", "_"))
      }
}

These version used to work in some older versions. At least I have many entries in my version.properties file which are now marked as "unused"

Using version 0.60.5

@jschneider jschneider changed the title NPM dependency with group not detected(!?) implementation(npm("@fontsource/inter", "_")) NPM dependency with group not detected(!?). E.g. npm("@fontsource/inter", "_") Apr 16, 2024
@jschneider
Copy link
Author

  • 0.40.2: Works
  • 0.50.0: does not work
  • 0.51.0: does not work
  • 0.60.5: does not work

@jschneider
Copy link
Author

The issue can be reproduced using https://github.com/Splitties/refreshVersions/tree/main/sample-kotlin-js
I changed the version to 0.60.5 and executed "./gradlew refreshVersions".
The version.properties file is updated and "unused" is added to the "@googlemaps/js-api-loader" dependency

@jschneider jschneider changed the title NPM dependency with group not detected(!?). E.g. npm("@fontsource/inter", "_") [Regression] NPM dependency with group not detected(!?). E.g. npm("@fontsource/inter", "_") Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant