Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace duplicated gradle wrappers by symlink and add samples CI check for 6.3+ #357

Closed
LouisCAD opened this issue May 18, 2021 · 4 comments · May be fixed by #626
Closed

Replace duplicated gradle wrappers by symlink and add samples CI check for 6.3+ #357

LouisCAD opened this issue May 18, 2021 · 4 comments · May be fixed by #626
Projects
Priorities 📝

Comments

@LouisCAD
Copy link
Member

No description provided.

@LouisCAD LouisCAD added this to Priorities in Priorities 📝 May 18, 2021
@NikkyAI
Copy link
Collaborator

NikkyAI commented Jun 14, 2021

symlinks make development really annoying on windows,
how about using the wrapper task instead in the samples?

@LouisCAD
Copy link
Member Author

how about using the wrapper task instead in the samples?

Can you be more specific?
I'm not sure how it would be used to avoid duplicates in the repo.

@NikkyAI
Copy link
Collaborator

NikkyAI commented Jun 15, 2021 •
edited by LouisCAD

idea can use the wrapper task to get the correct gradle version
and the gradle/ directory in the samples can be gitignored

the ci gradle steps can be configured to use gradle from a single directory

@NikkyAI NikkyAI mentioned this issue Jul 2, 2021
Closed
6 tasks
@jmfayard jmfayard moved this from Priorities to Backlog in Priorities 📝 Aug 8, 2021
@jmfayard
Copy link
Member

I'm sorry, I tried it a couple of times but it didn't work.
We can live with the duplication I guess

Priorities 📝 automation moved this from Backlog to Done Sep 13, 2022
@jmfayard jmfayard mentioned this issue Sep 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Priorities 📝
  
Done
Milestone
No milestone
3 participants
@jmfayard @NikkyAI @LouisCAD