New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAL-India workshop bugs #147
Comments
Just checking - have all of these been fixed by v0.1.5 of |
I've just updated the description. The The |
This is actually just a tolerance issue as the error message suggests. The We'll probably just leave the code as is rather than change the defaults or the cif. All other issues have been fixed. |
Bugs discovered during RAL-India workshop on neutron scattering data analysis.
(Fixed in Test sw_egrid #130)sw_egrid
invalid handling of half-polarized modecall_python
mex file to distribution (need CI modifications to compile it for all platforms). This would allow helper functions in Python to be used (e.g. forgenmagstr
, instead of the the providedgmplanar
etc.)Some Matlab command fails with incorrect(Fixed in libpymcr#20nargout
incall.m
(e.g.m.axis([0,1,0,2])
) [aMATLAB:nargoutchk:tooManyOutputs
error]Other minor bugs identified by users
lmo = spinw('LuMnO3.cif'); lmo.gencoupling
will give aSymmetry error!
. TheLuMnO3.cif
file is in the tutorials folder###sw_egrid
: invalid handling of half-polarized modeTo reproduce: calculate a spectrum, compute the polarised intensities and then try to plot the half-polarised cross-sections withPa
(a=x,y,z) component:This gives an errorMatrix dimensions must agree.
in line 424 ofsw_egrid.m
- which is due to the incorrect reshaping of theintP
property of the input spectra (computed fromsw_neutron
in line 388 which should be:intP{ii} = reshape(intP{ii},3,nMode,[]);
The text was updated successfully, but these errors were encountered: