User specified arguments in sw_plotspec ignored if 'mode', 'auto' (the default) used #132
Comments
mducle
added a commit
that referenced
this issue
Apr 25, 2024
Merged
mducle
added a commit
that referenced
this issue
May 20, 2024
* Fix bug where imag always plots in auto mode #172 * Allow row vector for hkl for single point #179 * Fix inverted user colormap #131 * Refactor sw_plotspec to avoid recursive calls #132 * Add fitspec fixes suggested by K Richardson #98 * Add spinw obj to spec for twin cases in fitspec #158 * Fix spec spinw object issues in fitmode spinwave() now creates a .obj field regardless When fitmode=true, this a barebones struct When fitmode=false, this is a full spinw object Fix issue with sw_plotspec when using fastmode/fitmode Add basic test for fitspec() to check twins handling * Fix bug in sw_plotspec 'fastmode' handling * Fix issues from review. Add change log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For
'mode', 'auto'(mode4) and for non-powder mode,sw_plotspectries to determine what type of spectra is being plotted and then calls itself again with'mode', 'disp'or'mode', 'color', however this second call ignores certain user arguments without warning.Specifically:
swConv(e.g. not run throughsw_egrid),sw_plotspeccalls itself again with'mode', 'disp'but overrides every argument except forqlabel.swConv, it calls itself again with'mode', 'color'but overridesdashed, andcolorbar.Behaviour 2 is ok, but behaviour 1 is quite annoying and unexpected for users.
sw_plotspecshould be refactored to either:'disp')The text was updated successfully, but these errors were encountered: