Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_scaled to Templates object (and zarr representatio) #2831

Closed
alejoe91 opened this issue May 10, 2024 · 4 comments
Closed

Add is_scaled to Templates object (and zarr representatio) #2831

alejoe91 opened this issue May 10, 2024 · 4 comments
Assignees
Labels
hybrid Related to Hybrid testing

Comments

@alejoe91
Copy link
Member

@h-mayorquin I think we should add a property to the Templates object to tell whether the templates_array is scaled to uV or not.

This will be extremely important for hybrid generation. Currently, we are "assuming" that templates in the database are scaled, so my suggestion is to be explicit about it.

Any thoughts?

@alejoe91 alejoe91 added the hybrid Related to Hybrid testing label May 10, 2024
@h-mayorquin
Copy link
Collaborator

I think this makes sense. Is there a situation where we can to deal with raw templates? I am having a hard time imaging this.

But I think it makes sense. Either that or we add a units property (.e.g "uV", "V" or "raw").

@samuelgarcia
Copy link
Member

Units is a good idea but if you go there this should be everywhere.
Now scaled = uV in all places.
So lets keep this for now and lets add units everywhere but later.

@h-mayorquin
Copy link
Collaborator

This makes sense, Sam. I will do it like this.

@zm711
Copy link
Collaborator

zm711 commented May 14, 2024

Closed by #2842.

@zm711 zm711 closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hybrid Related to Hybrid testing
Projects
None yet
Development

No branches or pull requests

4 participants