Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel aggregation preserves names #2797

Merged
merged 6 commits into from May 14, 2024
Merged

Channel aggregation preserves names #2797

merged 6 commits into from May 14, 2024

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented May 3, 2024 •
edited

This should fix #2789

This added a tests for what to do when the channels_ids are not unique or not shared type as discussed in the issue.

The only contentious issue is that it takes a stance on the issue #1432 by making the default strings.

@h-mayorquin h-mayorquin added the core Changes to core module label May 3, 2024
@h-mayorquin h-mayorquin self-assigned this May 3, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review May 3, 2024 01:43
@alejoe91 alejoe91 changed the title Channel agregation preserves names Channel aggregation preserves names May 10, 2024
@alejoe91 alejoe91 merged commit eb594f2 into SpikeInterface:main May 14, 2024
11 checks passed
@h-mayorquin h-mayorquin deleted the channel_agregation_preserves_names branch May 14, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zm711 zm711 zm711 left review comments

@alejoe91 alejoe91 alejoe91 approved these changes

Assignees

@h-mayorquin h-mayorquin

Labels
core Changes to core module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should aggregate channels preserve the channel_ids?
3 participants
@h-mayorquin @alejoe91 @zm711