Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW PROJECT]: Unify and speed up testing framework #8

Open
3 tasks
alejoe91 opened this issue Apr 22, 2024 · 7 comments · May be fixed by #9
Open
3 tasks

[NEW PROJECT]: Unify and speed up testing framework #8

alejoe91 opened this issue Apr 22, 2024 · 7 comments · May be fixed by #9

Comments

@alejoe91
Copy link
Member

Project title: Unify and speed up testing

Key Investigators

Project Description

SpikeInterface implements a large and diverse set of tests at the module level. While testing routines have been growing steadily as the package developed, there are certain behaviors that require some refactoring.
As an example, many test functions use custom cache folders for saving temporary files, other use pytest fixtures.

With this project, we aim to use the latest testing tools to clean up and speed up testing and CI.

Objectives

The goal of this project is to review and modify the SpikeInterface tests to be more consistent and lightweight.

Approach and Plan

  • Review existing test functions and identify old patterns that needs to be updated
  • Identify and move fixtures that can be used at the package level and shared across modules

Progress

  • Make PR to SpikeInterface
@paulrignanese
Copy link

upvote ! I'd be happy to help with that :)

@h-mayorquin
Copy link

Maybe finally add windows and the mac runners to the CI? Or should this be a project of their own?

@h-mayorquin
Copy link

Also, @chrishalcrow , mentioned that he had some difficultes just getting to run the tests to beging with. We should address those so running tests locally is more straighforward. I believe that the main culprit is probably datalad but @chrishalcrow

@Ashkees
Copy link

Ashkees commented May 7, 2024

This project sounds great and I would love to help. My understanding is that it would be good for someone like me who is mostly an end-user and has spent little time with the core code - is that the case?

@zm711
Copy link

zm711 commented May 7, 2024

Maybe finally add windows and the mac runners to the CI? Or should this be a project of their own?

I haven't got datalad+git-annex working on my Mac. So if you figure out a mac runner I would be eternally grateful. Will have my mac at the conference so we can test things locally first if needed and I think @chrishalcrow also has a mac.

@chrishalcrow
Copy link

This project sounds great and I would love to help. My understanding is that it would be good for someone like me who is mostly an end-user and has spent little time with the core code - is that the case?

Hello! Yes, you're right - examining and improving tests is a great way to get to know the code better, especially when you're not too familiar with it :) Come join us!

@chrishalcrow
Copy link

Maybe finally add windows and the mac runners to the CI? Or should this be a project of their own?

I haven't got datalad+git-annex working on my Mac. So if you figure out a mac runner I would be eternally grateful. Will have my mac at the conference so we can test things locally first if needed and I think @chrishalcrow also has a mac.

I'm currently on Mac, but will hopefully have all the OSs by the conference! I'll try and figure out what my problems are before the hackathon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants