Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MainPicker Screenshare on Linux Pops Up Three Times Before Sharing Screen #505

Open
2 of 7 tasks
TZProgrammer opened this issue Jan 6, 2024 · 5 comments
Open
2 of 7 tasks
Assignees
Labels
info:upstream Issue with WebCord's depencencies / thirdparty software info:Wayland Issues specific to Wayland, likely caused by lack of support by Electron / Chromium. type:bug Something isn't working

Comments

@TZProgrammer
Copy link

Acknowledgements

  • I have checked that there is no other issue describing the same or
    similar problem that I currently have, regardless if it has been
    closed or open.

  • This bug affects Discord website.

  • This issue is confirmed to be reproducible when WebCord is packaged
    on at least all three latest supported Electron major releases.

  • This issue is reproducible in Chrome, Chromium or any
    Chromium-based browser, e.g Brave or Edge (please write in
    Additional Context which browser you have used if it is neither
    Chrome nor unmodified Chromium).

  • There are no fixes done to master which resolves this issue.

  • My issue describes one of the unstable and/or not fully implemented
    features.

  • I have found a workaround to mitigate or temporarily fix this issue
    in affected releases (please write it in Additional context section
    below).

Operating System / Platform

🐧️ Linux

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

28.1.1

Application version

v4.6.1

Bug description

When clicking to share a display / window / region on file picker, the pop up appears again, up to an additional two times (three times total). The screen that is shared is the last one selected on the pop-up.

Additional context

For additional context, this I am running on Wayland.

@TZProgrammer TZProgrammer added the type:bug Something isn't working label Jan 6, 2024
@SpookySkeletons
Copy link

Electron 27 suffers this bug downgrade to 25 and it should stop

@SpacingBat3 SpacingBat3 added status:wontfix This will not be worked on info:upstream Issue with WebCord's depencencies / thirdparty software and removed status:wontfix This will not be worked on labels Jan 24, 2024
@SpacingBat3
Copy link
Owner

Maybe new way of handling getDisplayMedia API helps a bit there that was recently pushed to master?

I honestly have no clue how it works right now with Wayland, from my tests it might behave as it was in regular Chromium browser, so there might be no support for Linux for audio sharing at all. Again, if this behaves like in Chromium there's a better change that it will work fine with the audio sharing once that reach stable Chromium builds and Electron, since I dunno whenever the old method (i.e. via getUserMedia()) is going to be deprecated (or has already been) or not and if Electron devs will backport it in some way.

@SpacingBat3 SpacingBat3 added the info:Wayland Issues specific to Wayland, likely caused by lack of support by Electron / Chromium. label Feb 4, 2024
@SpacingBat3
Copy link
Owner

Maybe new way of handling getDisplayMedia API helps a bit there that was recently pushed to master?

Since this is now in v4.7.0 and I've tested it on my local repo build with Wayland, I can tell this doesn't happen for me on GNOME under Wayland. Yet again, screen sharing doesn't work for me at all with my current drivers (which is nouveau with GSP.bin loaded) and after choosing the window or screen as a screen share source, gnome-shell crashes for me which is indicated in dmesg by nouveau. On X11 with my current drivers, it works all just fine so I might as well stay on X until things will get more stable on Wayland (my experience with Wayland still sometimes feels like it is in beta, especially in DE's that has been recently made or ported to Wayland).

@niko-roether
Copy link

If this helps, I'm experiencing this issue running WebCord v4.7.1 on Arch Linux with Hyprland and xdg-desktop-portal-hyprland. It affects the discord web app as well.

@medv
Copy link

medv commented Mar 3, 2024

If this helps, I'm experiencing this issue running WebCord v4.7.1 on Arch Linux with Hyprland and xdg-desktop-portal-hyprland. It affects the discord web app as well.

Same situation on nixos with hyprland.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:upstream Issue with WebCord's depencencies / thirdparty software info:Wayland Issues specific to Wayland, likely caused by lack of support by Electron / Chromium. type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants