Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase navigation doesn't make sense on alternative transcripts #196

Open
andrewgodwin opened this issue Apr 30, 2011 · 3 comments
Open

Phase navigation doesn't make sense on alternative transcripts #196

andrewgodwin opened this issue Apr 30, 2011 · 3 comments

Comments

@andrewgodwin
Copy link
Member

On the new alternative transcripts (for example, CM on Apollo 13), the phase navigation still exists at the bottom of the page, but it doesn't necessarily make sense - for example, there's no content for phases 1 or 8 on a13/CM, and so attempting to click "back" from phase 2 results in a mysterious error.

We first need to decide, from a design standpoint, what to do - drop the arrows if there's no phase that way for this transcript? Switch transcripts to one that does have content? Hide the phase navigation completely?

SteveMarshall added a commit that referenced this issue Apr 30, 2011
…s, and such. All we should need now is designs for switching UI, and to implement that UI.

See also bug #196 for an issue with phase navigation on alternate transcripts.
@jaylett
Copy link
Member

jaylett commented May 1, 2011

While we don't get an error, at the moment this is confusing: hitting back on phase 2 A11 CM just shows phase 2 again but with a different URL. It really needs instead to say "nothing happened in this transcript" or something?

@SteveMarshall
Copy link
Member

Agreed, @jaylett. That could be reasonably… interesting to implement, IIRC, because of the way we’re querying redis (everything after timestamp for n items).

@jaylett
Copy link
Member

jaylett commented Jun 5, 2011

But we can easily check if the first item is outside the phase we're supposed to be in. In fact, wouldn't we run into the same problem if a phase were shorter than the n items we fetch from redis? Or is that covered by the page restriction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants