Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long key moment text looks strange #174

Open
jaylett opened this issue Mar 6, 2011 · 4 comments
Open

Long key moment text looks strange #174

jaylett opened this issue Mar 6, 2011 · 4 comments
Labels
Milestone

Comments

@jaylett
Copy link
Member

jaylett commented Mar 6, 2011

See https://skitch.com/jaylett/ruj8u/screen-shot-2011-03-06-at-18.16.37 for an example.

@jaylett
Copy link
Member Author

jaylett commented Mar 27, 2011

Appears to only be when multiple loglines are selected.

@ghost ghost assigned SteveMarshall Apr 10, 2011
@SteveMarshall
Copy link
Member

This is happening because we’re setting .highlighted per-logline and the key-scene text is being hidden by the background colour set by that class being applied to the subsequent logline.

Solution I’m probably going to take is to wrap loglines for selection. This may hurt a little.

@SteveMarshall
Copy link
Member

Actually, it seems like this is a bit of a bugger to fix. I think (unless I’m missing something painfully easy), it’ll require rewriting much of the CSS for highlighting, along with probably all (or close to it) of the highlighting JS logic and some of the template logic, too.

I’m going to leave it for the moment; if someone else is feeling brave, by all means have a go. Otherwise, I propose waiting till the next flat (in 3 weeks).

@ghost ghost assigned SteveMarshall Apr 30, 2011
@jaylett
Copy link
Member Author

jaylett commented Jul 25, 2011

Suspect best done as part of #110.

@SteveMarshall SteveMarshall removed their assignment Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants