Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] do not mark additional flavors as an error #574

Closed
berendt opened this issue Apr 21, 2024 · 5 comments · Fixed by #593
Closed

[BUG] do not mark additional flavors as an error #574

berendt opened this issue Apr 21, 2024 · 5 comments · Fixed by #593
Assignees
Labels
bug Something isn't working SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10
Milestone

Comments

@berendt
Copy link
Member

berendt commented Apr 21, 2024

We have additional flavors which are not listed in the SCS standard and which contain all the necessary metadata. If these are present, they should not be marked as errors. The names of the flavors are valid according to the SCS standard.

ERROR: The following flavors are not standard, yet use a reserved property: SCS-2V-4-20: scs:name-v1, scs:name-v2, SCS-4V-8-50s: scs:name-v1, scs:name-v2, SCS-4V-8-50: scs:name-v1, scs:name-v2, SCS-8V-32-50: scs:name-v1, scs:name-v2, SCS-8V-64: scs:name-v1, scs:name-v2, SCS-1V-1-10: scs:name-v1, scs:name-v2
@berendt berendt added the bug Something isn't working label Apr 21, 2024
@mbuechse
Copy link
Contributor

The test simply does what the standard says:

scs:name-vN=NAME (where N is 1 or 2, and NAME is some string) means that the flavor is one of the standard SCS flavors, and the requirements of Section "Standard SCS flavors" below apply.

@berendt
Copy link
Member Author

berendt commented Apr 22, 2024

But does that make sense? I would like to define flavors according to the SCS standard, but they are not specified as recommended or must in the standard. IMO, it makes sense to include all SCS meta information for these flavors as well.

@berendt
Copy link
Member Author

berendt commented May 2, 2024

@garloff Please have a look. We were supposed to discuss it today, but there wasn't time. Our v4 check is currently red as we are adding SCS metadata to flavors that are not listed as mandatory or recommended. I think that should be fine to provide additional flavors. At the moment, we're just not really sure how this is intended in the standard.

@mbuechse
Copy link
Contributor

mbuechse commented May 16, 2024

Kurt asked me via e-mail about the rationale, and I think it's not unappropriate to also reproduce my response here:

  • this standard was only a first shot at standardizing the extra_specs, so we wanted to gather some experience with it before rolling it out more widely;

  • one of the aims of this standard and the extra_specs was to obviate the need for flavor names in the first place (which need careful parsing, for instance, to differentiate between _i for Intel and _ib for Infiniband), so we didn't want to proliferate those;

  • only the mandatory and recommended flavors can be counted on to be present in general, so those can be found by name; all the other flavors would have to be selected in a more advanced manner, and then we can as well use the other extra_specs instead of the name.

  • the names for the mandatory and recommended flavors are listed in the same standard, whereas for all other names, one would have to refer to the standard about flavor naming, and this would pose two problems:

    1. the standard would no longer be self-contained (with consequences for the test scripts); and
    2. which major version to refer to?

We would have to refer to some major version, or we would have to introduce some complicated mechanism by which it could be inferred from the context which one would apply. The context could be the certificate scope, but then these two realms would start bleeding into each other, which feels messy to me.

@mbuechse mbuechse added SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10 labels May 17, 2024
@mbuechse mbuechse added this to the R7 (v8.0.0) milestone May 17, 2024
@mbuechse
Copy link
Contributor

mbuechse commented May 17, 2024

As discussed yesterday both in personal conversation and the SIG Std/Cert, it seems that this part of the standard (however many reasons it may have) doesn't work for the customers, so with the associated Pull Request we relax the test so as no longer to enforce said part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants