Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IMDB Link to Telegram Notifications #5342

Open
1 task done
Zantag opened this issue Jan 3, 2023 · 8 comments · May be fixed by #6613
Open
1 task done

Add IMDB Link to Telegram Notifications #5342

Zantag opened this issue Jan 3, 2023 · 8 comments · May be fixed by #6613

Comments

@Zantag
Copy link

Zantag commented Jan 3, 2023

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Is your feature request related to a problem? Please describe

I have telegram group with telegram bot connected to sonarr, radarr and bazarr.
The notifications from radarr has imdb link... notifications from sonarr doesn't... in the example below you will see how bad look like the notification from sonarr without preview from the imdb link...
image

Describe the solution you'd like

I want just to add imdb link for the tv series in all notification connected to telegram bots... the same way used in radarr.

Describe alternatives you've considered

Hope this will be not hard to be integrated in the notifications feature...

Anything else?

No response

@markus101 markus101 changed the title Telegram notification with imdb link just like radarr... Add IMDB Link to Telegram Notifications Jan 3, 2023
@markus101
Copy link
Member

I imagine Radarr always has IMDB IDs, but for Sonarr that's not always the case, it'd be more reliable to have TheTVDB links instead.

@Zantag
Copy link
Author

Zantag commented Jan 4, 2023

I imagine Radarr always has IMDB IDs, but for Sonarr that's not always the case, it'd be more reliable to have TheTVDB links instead.
Every TV series on my sonarr has IMDB link... The links from IMDB also has nice preview... So i prefer IMDB.

image

Trakt also is good:
image

@markus101
Copy link
Member

Making it optional and giving a choice should be easy enough whenever someone picks this up.

@ricci2511
Copy link

ricci2511 commented Aug 1, 2023

I recently thought about this too.
I guess the easy way would be adding the imdb url in the GetMessage method in NotificationService.cs just like Radarr does. But maybe you have something else in mind? @markus101

@Adair-GA
Copy link

I can do this, it does't seem to be really hard, but I'm a bit confused as how would I make it an optional feture. It seems that it could either be an option for the telegram connection, or it could be included in the GetMessage method, but that would make it appear on all connections, and I don't see how could I make that optional.

@markus101
Copy link
Member

I don't think we want to add it to every message by adding to to NotificationService.

The simplest solution would be to add an option to TelegramSettings, then conditionally append it to the message before sending, which can be done with a function in Telegram.cs that takes the message input and outputs the updated message.

@qTipTip
Copy link

qTipTip commented Mar 8, 2024

I'd be happy to take a shot at this if nobody else has given it a go. I've already put together a reference implementation that includes an IMDb link. However, I'm a bit uncertain about how to generate a TVDb URL from the ID. It would be great to have a conditional setting that allows you to pick the database you prefer, although we should be careful not to make it overly complex. If IMDb suits your needs, that would be the most straightforward option.

Screenshot 2024-03-09 003426
Screenshot 2024-03-09 001358

@markus101
Copy link
Member

I'm a bit uncertain about how to generate a TVDb URL from the ID

Series details uses the IDs to create links to the various metadata sites so you can see how it's done there.

It would be great to have a conditional setting that allows you to pick the database you prefer, although we should be careful not to make it overly complex

There are quite a few examples where an enum is used to generate a select list on the UI (ReleaseTypeSpecification for Custom Formats is a recently added example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants