New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Want hard links only, no copies. #6260
Comments
This sounds more like a configuration issue. With a properly configured setup, Sonarr should always use hardlinks. Please use one of the official support channels like Discord or the Sonarr forum instead. |
There are circumstances that even a properly configured setup can cause Sonarr to copy. Very simple: If the user wants Sonarr to hard link, then only allow hard linking. Do not even allow copying. If that cannot easily be achieved, at least provide an error/warning message. Proposal: If either of those options is not successful, inform the user of an error, exit import process. Do NOT switch import modes. Thank you. |
Can you elaborate with examples?
Is your issue only with Manual Import?
I see no reason to remove |
Would it be fair to summarize your very high level issue is that you thought you had a hard links setup, but didn't. But this is very hard to realize, both investigating yourself and in sonarr/radarr where there are no indicators? It is fine to think about solutions, but it helps a lot to step way back and look at the high level problem so we can figure out a variety of approaches. As someone who cares a lot about hard links, this has been an issue for years and years and years and I think it would be great to help people end up w/ a good setup that supports hard links and instant moves. :) |
the importing section is what is done by default when the system is auto importing. the manual import, the option are there is to provide flexibility for the scenario rather than not give an option and force the user to dig into settings to change it. |
not my issue, just responding because i think its a good idea. yes, that big picture description sounds about right for me. i presumed i had mine setup for hardlinks but the only way i could think to confirm was to watch a torrent being copied across - if it took a couple of seconds to turn up (and the file size incremented) then it was copying, if it turned up instantly at full size then it was hardlinking. even then though some werent large enough to tell so it wasnt exactly good confirmation. theres probably some way to tell at the os level that the file is a hardlink or not but i use a synology nas and while i could get in there and check via ssh its not really something that should need to happen. its probably simpler to update the log entry output to indicate which method, copy or hardlink, was used for copying that file, at least then the users are capable of seeing for themselves that while they thought they had their system setup correctly for hardlinking, it seems they actually dont. ie, if you really want people to use hardlinking then shouldnt you make it easy for them to find out if they (sonarr or radarr) are or not? |
+1 to this. I find in my current setup (v4.0.0.748), copies are still happening when logs depict hardlinking is working fine. How do I know this?
See this line when doing This seems indicative of an underlying problem I'd like to address, but to combat it, having this suggestion be implemented would def help. Don't want sonarr just doubling my disk size, i'd rather it halt and tell me, or give me the option to enable this (to your point of not troubling the standard OOB UEX). |
Any and all documentation from sonarr's docs to the wiki to trash guides to LSIO's own readme says to avoid this path setup if you want hardlinks. |
Can you elaborate? See log message in post. Directories on different, root dir is tv and downloads dir is downloads. Isn't that explicitly what the docs say to do? Also, why wouldn't the debug logs tell me this when it is running DiskTransferService? |
From LSIO: From Sonarr wiki: From Trash: |
|
Should have been more explicit. This is truenas core running on baremetal. I have 1 dataset called media, within it 3 dirs. tv, movie, downloads. I mount with full control perms to a FreeBSD Jail, and then ACL the *arr group to have full read/write on it. Is this what makes it docker-like? I saw Trash guides mention this for truenas scale, but core has its own section. This line you shared does perplex me though
Does this mean if you name your dirs this way, regardless, hardlinks wont work? |
Naming has nothing to do with it. It is impossible to hardlink across multiple mounts/filesystems Unfortunately very few bsd users exist, so you'll need to rely on the TrueNAS core community or yourself for support logs indicate that it will attempt to hardlink or copy. The user knows whether or not their setup supports hardlinks copies if they read the documentation. |
Alas the suggestion still is valid in my opinion, your logs don't indicate there is an issue with Hardlinking. If it tries and failsover to copy, some kind of line or halt would be beneficial. Knowing it attempted one or the other but not knowing what it chose is only somewhat useful. |
Fixed my issue, even though the local OS thinks everything is mounted to 1 place, it was 3 separate mounts from the iocage side. I just mounted ONLY the root media to the jail and now everything works since subdir structure is the same. Thanks for your help @bakerboy448 |
16e5ffa Clarified the misleading hardlink messaging |
Is there an existing issue for this?
Is your feature request related to a problem? Please describe
When importing, I do NOT want copies. I want hard links only.
Describe the solution you'd like
I want Sonarr to hard link the file, or throw an error.
Describe alternatives you've considered
Couldn't find an alternative.
Anything else?
Sonarr v3.0.10.1567
Linux
The text was updated successfully, but these errors were encountered: