Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 576p Bluray Resolution #6203

Open
1 task done
zakkarry opened this issue Nov 21, 2023 · 4 comments
Open
1 task done

Add 576p Bluray Resolution #6203

zakkarry opened this issue Nov 21, 2023 · 4 comments

Comments

@zakkarry
Copy link

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Is your feature request related to a problem? Please describe

if (resolution == Resolution.R360P || resolution == Resolution.R480P ||
resolution == Resolution.R540p || resolution == Resolution.R576p)
{
result.Quality = Quality.Bluray480p;
return result;
}

This causes 576p to incorrectly parse, not as 576p but 480p instead.

This also applies to 360p and 540p but those are admittedly much less common than 576 would be.

Describe the solution you'd like

Correctly identify 576p

Describe alternatives you've considered

.

Anything else?

No response

@markus101 markus101 changed the title fear(parser/resolution: support 576p resolution Add 576p Bluray Resolution Nov 21, 2023
@markus101
Copy link
Member

This will need to be a new separate quality, for existing profiles it'll be added, but not enabled. For the default profiles it should be enabled in Any/SD profiles.

@Voyex
Copy link

Voyex commented Dec 22, 2023

I'm currently working on this and I will put in a PR once I have finished testing.

@Voyex Voyex mentioned this issue Dec 23, 2023
2 tasks
Voyex added a commit to Voyex/Sonarr that referenced this issue Dec 23, 2023
@zakkarry
Copy link
Author

@Voyex have you abandoned this?

@Voyex
Copy link

Voyex commented Apr 26, 2024

@Voyex have you abandoned this?

Yes, due to hardware issues, I was unable to get my dev environment setup in a stable manner so I am unable to do any more work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants