Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually selecting release and mapping doesn't carry over to import queue and requires manual import also #6147

Open
1 task done
ZerkerEOD opened this issue Nov 2, 2023 · 11 comments

Comments

@ZerkerEOD
Copy link

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Current Behavior

When manually importing and selecting the episode mapping, it doesn't carry over to auto import and doesn't keep the episode mapping.

Expected Behavior

When manually searching and selecting the episode mapping, it should be able to auto-import with the mapping selected during the initial download as it should be assumed that it was already reviewed.

Steps To Reproduce

When I perform a manual search for an episode that has known issues such as American Dad, and find the episode I want based off of the name.

image

Then I click the override and add to queue button, below is what is portrayed even though asking for s3e11 it defaults to s4e11. Now that isn't as much of a problem but I think if doing manual search it should default to the episode I am looking for as I am selecting it.

image

Now comes what I think is the bug, If I edit it telling it no, I want it mapped to s3e11, then I would think that I have already told it it's correct mapping and it should be done.

image

So, I grab the release thinking it is all good, but it isn't. Now, I have to go back into the queue and see it didn't import.

image

Then I have to manually import it and select the season and episode again.

Environment

- OS: Unraid
- Sonarr: 4.0.0.688
- Docker Install: Yes
- Using Reverse Proxy: Yes, but in this instance I am directly connected to the instance with no proxy
- Browser: Brave/Chrome
- Database: Sqlite 3.41.2

What branch are you running?

Develop

Trace Logs?

The reproduction with the trace logs are for American Dad S3E12 named A.T. The Abusive Terrestrial with gets mapped to S4E12 as it looks like there is way more in the log and would help identify the path that the specific episode is on.

https://pastebin.com/wq0tC1SD

Anything else?

I think I managed to capture what I am seeing and what I was expecting above and I hope it helps.

@bakerboy448
Copy link
Contributor

If SQ is following TVDb not xem submit a mapping request - https://wiki.servarr.com/sonarr/faq#problematic-shows

@ZerkerEOD
Copy link
Author

@bakerboy448, it is already on the request and it is a known bad which I understand. I think the bug is when I manually search and select the release that I want it fails to auto import with what I selected which was already reviewed manually before the request. I don't think the mapping would work either way as the episodes are all messed up which is why I am manually looking for ones with the episode title included so I can verify it isn't for a different mapped episode.

@stevietv
Copy link
Member

stevietv commented Nov 2, 2023

Indeed, the Overrride and Grab is not sticky from grab to import, This is currently intentional, as Sonarr parses release name on grab and filename on import, and thus making it not stick ensures that there isn't an incorrect file in the download.

@ZerkerEOD
Copy link
Author

Am I missing something then, a lot of the episodes I download turn out to be an encoded file name like such.
image

@ZerkerEOD
Copy link
Author

Update, I found an option to deobfuscate file names and checked it. @stevietv, the import still does not appear to be working off the file name though
image

@stevietv
Copy link
Member

stevietv commented Nov 3, 2023

Sonarr is parsing again S07E01 to be Season 8 Episode one - in this case due to TheXEM,info mappings present for this show.
No matter what you set as override on grab sonarr will parse the filename again before importing

@markus101
Copy link
Member

This is quite a complex problem because there is no guarantee that there is a 1:1 mapping between files in the release and the release name, regardless of what you've selected. A multi-episode release could be 1 file or it could be 1 for each file, a season pack may be incomplete or poorly named so Sonarr can't discern what is what.

We can likely improve this scenario for a small subset of manually mapped and grabbed releases, but we'll need to make sure it doesn't extend beyond single file releases and potentially only when a single episode is grabbed, but definitely not season packs.

@ZerkerEOD
Copy link
Author

@markus101, I agree that it shouldn't work for season packs, that could cause a ton of issues. I'm only talking about when manually searching and selecting an episode to download, if it's a season packs I would prefer it to fail and need to be manually imported as well.

@nirurin

This comment was marked as off-topic.

@Xevion

This comment was marked as off-topic.

@bakerboy448

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants